Skip to content

feat: improve caching by only decoding jwks when necessary #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 8, 2023
Merged

feat: improve caching by only decoding jwks when necessary #486

merged 4 commits into from
Feb 8, 2023

Conversation

bshaffer
Copy link
Collaborator

@bshaffer bshaffer commented Feb 5, 2023

addresses #481

Calls JWK::parseKey on the matching key instead of calling JWK::parseKeySet on the whole response

@bshaffer bshaffer mentioned this pull request Feb 5, 2023
Closed
@bshaffer bshaffer merged commit 78d3ed1 into main Feb 8, 2023
@bshaffer bshaffer deleted the improve-keyset-caching branch February 8, 2023 14:14
@release-please release-please bot mentioned this pull request Feb 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@SoulPancake SoulPancake SoulPancake approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bshaffer @SoulPancake