Skip to content

Conversation

bshaffer
Copy link
Collaborator

fixes #543

Without setting the cached item expiry every time, the expiry is not persisted. In order to address this, we cache an array instead of an integer for the rate limit in the CachedKeySet class.

Copy link

@ajupazhamayil ajupazhamayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

@bshaffer bshaffer merged commit 09cb208 into main May 18, 2024
@bshaffer bshaffer deleted the fix-ratelimit-expiry branch May 18, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rate limit cache expiration is not working as expect in CachedKeySet.php
4 participants