Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing ArrayAccess-type for $keyOrKeyArray in decode() #443

Merged
merged 4 commits into from
Apr 5, 2023

Conversation

ppaulis
Copy link

@ppaulis ppaulis commented Aug 1, 2022

Signed-off-by: Pascal Paulis ppaulis@gmail.com

This PR adds the missing type ArrayAccess to the docblock of the decode() method.

Following the code:

$key = self::getKey($keyOrKeyArray, property_exists($header, 'kid') ? $header->kid : null);

getKey() already expects a CachedKeySet (that implements ArrayAccess).

Signed-off-by: Pascal Paulis <ppaulis@gmail.com>
@google-cla
Copy link

google-cla bot commented Aug 1, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bshaffer bshaffer enabled auto-merge (squash) April 5, 2023 20:59
@bshaffer bshaffer merged commit 705d6a3 into firebase:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants