-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
would like to use wofi instead of rofi for pure wayland #71
Comments
Sorry for the delay in responding! I haven't experimented with Wayland at all yet. I did a quick browse of the wofi repo, but didn't have time to dig into the docs. Are you able to figure out which command line options would need alteration in order to make it work? |
|
to make it compatible, add this to the file
|
Seems the 'fn' option messes it up. works with -d, without the 'fn' option set. |
I don't really mind the font, but I would really like to have pango markup support. |
@chron-isch I doubt pango markup is something I will add. In my opinion that adds a pretty substantial complexity for a minimalist tool that is rarely visible. |
@firecat53 I think you misunderstood my comment, i wasn't asking for generic pango markup support, just replacing the rofi highlighting code with a little bit of pango markup to get highlighting of active network connections to work in wofi. |
@chron-isch : Ah, I see. I'd be happy to review a PR if you'd care to take a stab at it. |
There's also a fork of https://github.com/lbonn/rofi#wayland-support Not everything works though-- notably the window switching mode is not supported. However, there is a
However, since rofi supports custom modes that supply their own scripts, perhaps this approach could be used as the basis to implement a window switching mode for Sway, using the Wayland fork of |
Where to find the PR for the Wofi implementation? |
@mordax777 The comment above describes how to make it work for |
@firecat53 You already handle rofi with a special case, can you add one for wofi too: if "rofi" in dmenu_command:
lines = "-i -dmenu -lines"
# rofi doesn't support 0 length line, it requires at least -lines=1
# see https://github.com/DaveDavenport/rofi/issues/252
num_lines = num_lines or 1
#wofi takes lines as `-L`
elif "wofi" in dmenu_command:
lines = "--dmenu -i -L"
else:
lines = "-i -l" #71 (comment) will work for wofi except the argument for specifying lines is |
wofi has slightly different arguments to rofi, so unfortunately not just a drop in replacement
The text was updated successfully, but these errors were encountered: