Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds option to list saved connections #74

Closed
wants to merge 1 commit into from

Conversation

zzzdeb
Copy link
Contributor

@zzzdeb zzzdeb commented Mar 28, 2020

refering to this issue:
#72

@firecat53
Copy link
Owner

Thanks for the PR!

Another solution could be adding a menu entry at the bottom to Show saved connections that opens a separate list of just saved connections and not needing another config option. It's just an idea...which do you think would be better/easier for the users?

Also, what do you think about moving the saved list below the menu items so the menu items (delete, rescan, etc) are more visible?

Finally, can you please update the README to reflect whatever changes we decide on?

Thanks!!

@zzzdeb
Copy link
Contributor Author

zzzdeb commented Apr 6, 2020

With pleasure!

Adding submenu is at least for me undesirable. For now, with ~3 letters, I am able to find my desired network and I think, it is in most cases so. So I think enabling it by default, and to be able to disable it by config is mostly efficient.

As for putting them on bottom, I totally agree, it is indeed more visible.

Should I create another pl?

@firecat53
Copy link
Owner

You should be able to just add and push commits to the branch from which you created the PR.

@firecat53 firecat53 closed this in 8e8abff May 22, 2020
@firecat53
Copy link
Owner

firecat53 commented May 22, 2020

Went ahead and finished this up and merged it. Thanks!

Edit: FYI, I did switch the default to False for list_saved and moved it under the [dmenu] heading just for simplicity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants