Allow drive paths already in the jailer rootfs #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, when providing a drive which is already in the jailer rootfs, the LinkFilesHandler would fail trying to hard-link the file to the path where it is already linked. This commit makes it so that we skip the hard-link step in this case. This change allows provisioning virtual drive contents via FUSE, so that the drive contents can be lazily fetched from a remote server. The FUSE mount needs to be set up in the chroot ahead of time, because FUSE files can't be hard-linked across filesystem boundaries. Signed-off-by: Brandon Duffany <brandon@buildbuddy.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, when providing a drive which is already in the jailer
rootfs, the LinkFilesHandler would fail trying to hard-link the
file to the path where it is already linked.
This commit makes it so that we skip the hard-link step in this case.
This change allows provisioning virtual drive contents via FUSE, so
that the drive contents can be lazily fetched from a remote server.
The FUSE mount needs to be set up in the chroot ahead of time,
because FUSE files can't be hard-linked across filesystem boundaries.