use upstream kvm-ioctls #2319
Merged
use upstream kvm-ioctls #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandreim
previously approved these changes
Dec 4, 2020
This should reduce the burden of maintaining forks of both kvm-ioctls and kvm-bindings, and allows us to use the upsream kvm-ioctls while only replacing the kvm-bindings dependency with one that supports versionize. As part of this switch, an update to the tests was also needed because the KVM::new_with_fd_number was removed. The same functionality is offered through the from_raw_fd method. Signed-off-by: Andreea Florescu <fandree@amazon.com>
andreeaflorescu
force-pushed
the
use_upstream_kvm_ioctls
branch
from
a785f2a
to
5085831
Compare
acatangiu
approved these changes
Dec 4, 2020
sandreim
approved these changes
Dec 4, 2020
This was referenced Dec 8, 2020
kumargu
added a commit
to kumargu/firecracker
that referenced
this pull request
Dec 8, 2020
fix crate path of vm_memory Signed-off-by: kumargu <kumargu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
This purpose of this PR is to reduce the overhead needed for maintaining, and releasing the firecracker-microvm/kvm-ioctls fork. The changes enable using the upstream kvm-ioctls, while still keeping the kvm-bindings + versionize support.
Description of Changes
This should reduce the burden of maintaining forks of both kvm-ioctls
and kvm-bindings, and allows us to use the upsream kvm-ioctls while only
replacing the kvm-bindings dependency with one that supports versionize.
rust-vmm.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).unsafecode is properly documented.firecracker/swagger.yaml.CHANGELOG.md.