Add CPU template benchmarking for JSON ops #3618
Conversation
mattschlebusch
force-pushed
the
cpu-config-benchmark
branch
8 times, most recently
from
e9ff78f
to
8cf0824
Compare
mattschlebusch
added
the
Status: Awaiting review
tests/integration_tests/performance/test_cpu_template_benchmark.py
Outdated
Show resolved
Hide resolved
tests/integration_tests/performance/test_cpu_template_benchmark.py
Outdated
Show resolved
Hide resolved
mattschlebusch
force-pushed
the
cpu-config-benchmark
branch
2 times, most recently
from
1e31050
to
9ac20cd
Compare
Minimizes duplicating the creation of test data, specifically for CustomCpuTemplate and CpuConfiguration. Signed-off-by: Matthew Schlebusch <schlebus@amazon.com>
mattschlebusch
force-pushed
the
cpu-config-benchmark
branch
from
9ac20cd
to
99ea8d4
Compare
This change includes some minor refactoring to support different criterion benchmarks. Signed-off-by: Matthew Schlebusch <schlebus@amazon.com>
Signed-off-by: Matthew Schlebusch <schlebus@amazon.com>
Signed-off-by: Matthew Schlebusch <schlebus@amazon.com>
mattschlebusch
force-pushed
the
cpu-config-benchmark
branch
from
99ea8d4
to
c351582
Compare
There was a problem hiding this comment.
My main comment is do we really need these as part of the PR CI tests?
If I understand correctly, this essentially is benchmarking the serde implementation. I remember we had a discussion regarding a similar situation with versionize.
In any case, my main concern is whether we might add another good candidate for intermittent failures in the CI, blocking PRs, for testing something that is not Firecracker specific.
There was a problem hiding this comment.
If I understand correctly, this essentially is benchmarking the serde implementation. I remember we had a discussion regarding a similar situation with versionize.
Not quite. There is quite a bit of custom serialization and deserialization code for the fields in the CustomCpuTemplate type.
In any case, my main concern is whether we might add another good candidate for intermittent failures in the CI, blocking PRs, for testing something that is not Firecracker specific.
The format of the template and the custom processing we include for the fields in the template is not using default derivations unfortunately.
Changes
Add criterion benchmarks for the to/from string JSON operations for the
CustomCpuTemplatetype.Reason
To keep a handle on the performance of serializing and deserializing CPU templates in JSON format.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
[
CONTRIBUTING.md][3].