chore(ci): double pytest timeout duration temporarily #4634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently our A/B testing builds Firecracker for each test and each environment while running tests. As the Firecracker build time increases, some tests timeout the current duration (300s). To mitigate this issue temporarily, sets it to 600s. It should be set it back to the original value after fixing the issue in PR firecracker-microvm#4624. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
zulinx86
added
the
Status: Awaiting review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4634 +/- ##
=======================================
Coverage 82.10% 82.10%
=======================================
Files 255 255
Lines 31280 31280
=======================================
Hits 25681 25681
Misses 5599 5599
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pb8o
approved these changes
Jun 5, 2024
roypat
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
Currently our A/B testing builds Firecracker for each test and each environment while running tests. As the Firecracker build time increases, some tests timeout the current duration (300s).
Changes
To mitigate this issue temporarily, sets it to 600s. It should be set it back to the original value after fixing the issue in PR #4624.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] If a specific issue led to this PR, this PR closes the issue.[ ] Any required documentation changes (code and docs) are included in thisPR.
[ ] API changes follow the Runbook for Firecracker API changes.[ ] User-facing changes are mentioned inCHANGELOG.md.[ ] All added/changed functionality is tested.TODOs link to an issue. => the new TODO to be removed in PR CI: build Firecracker once and share it with all the jobs #4624.contribution quality standards.
rust-vmm.