README instructions are outdated #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joffref
reviewed
Nov 18, 2022
| sha256sum -c firectl.sha256 | ||
| mv firectl-v0.2.0 firectl |
There was a problem hiding this comment.
Why not directly set the name of firectl in the curl command ?
There was a problem hiding this comment.
Agreed; it was simpler the other way.
Joffref
reviewed
Nov 18, 2022
| curl -Lo firecracker.tgz https://github.com/firecracker-microvm/firecracker/releases/download/v1.1.2/firecracker-v1.1.2-x86_64.tgz | ||
| tar -xvf firecracker.tgz | ||
| mv release-v1.1.2-x86_64/firecracker-v1.1.2-x86_64 firecracker | ||
| rm -rf firecracker.tgz release-v1.1.2-x86_64 |
There was a problem hiding this comment.
Personally I feel like deleting the zip and the unzipped content is not necessary in the README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
I'm not sure if these are the exact instructions that should be in the README. Instead, they're the commands that worked for me to get the latest versions of both firectl and firecracker.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.