Constant and derivative #3261
Merged
Constant and derivative #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbouziani
reviewed
Nov 23, 2023
firedrake/constant.py
Outdated
Comment on lines
211
to
224
| def _unicode_format_firedrake_constant(self, o): | ||
| """Format a Firedrake constant.""" | ||
| i = o.count() | ||
| var = "💩" | ||
| if len(o.ufl_shape) == 1: | ||
| var += UC.combining_right_arrow_above | ||
| elif len(o.ufl_shape) > 1 and self.colorama_bold: | ||
| var = f"{colorama.Style.BRIGHT}{var}{colorama.Style.RESET_ALL}" | ||
| return f"{var}{subscript_number(i)}" | ||
|
|
||
|
|
||
| # This monkey patches ufl2unicode support for Firedrake constants | ||
| Expression2UnicodeHandler.firedrake_constant = _unicode_format_firedrake_constant |
There was a problem hiding this comment.
I don't think that's the right place to add ufl2unicode support for constants, see my comment here.
There was a problem hiding this comment.
I agree, this code is disgusting. I envision my code as being a temporary workaround current issues whilst someone with more UFL skills fixes this upstream.
pbrubeck
reviewed
Nov 23, 2023
pbrubeck
reviewed
Nov 23, 2023
JDBetteridge
force-pushed
the
JDBetteridge/constant_and_derivative
branch
from
7b83329
to
852e8ed
Compare
connorjward
previously requested changes
Mar 5, 2024
There was a problem hiding this comment.
I think this is basically fine, but a better mathematician than me should really take a look at this.
I think eventually we might want to consider dropping support for differentiating wrt constants. Downstream users that rely on this functionality (hopefully not many!) could do the replacement themselves.
Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
dham
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improvements to some oversights with the changes I previously made to
Constant.derivativenow substitutes the symbolic constant back into the form after taking the derivative. This allows the user to perform solves with the resultant form, which was not the case before.ufl2unicodesupport forConstantvia various hackery.