Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code clean up and refactoring #12

Merged
merged 5 commits into from
Feb 26, 2022
Merged

Code clean up and refactoring #12

merged 5 commits into from
Feb 26, 2022

Conversation

zStupan
Copy link
Collaborator

@zStupan zStupan commented Feb 26, 2022

  • Updated dependencies
  • Finished the Stats class implementation
  • Refactored NiaARM class and AssociatonRule class
  • Cleaned up the code mostly

EDIT: in the association rule class there's an if statement where both branches do the same thing:

if self.features[self.permutation[i + len(antecedent)]].dtype == "cat":
rule = self.features[self.permutation[i + len(antecedent)]].name + "(" + str(consequence[i]) + ")"
else:
rule = self.features[self.permutation[i + len(antecedent)]].name + "(" + str(consequence[i]) + ")"

I'm guessing it should be consequence[i][0]?

@firefly-cpp
Copy link
Owner

Thanks @zStupan. This is great! Thanks for all the hardwork.

@firefly-cpp firefly-cpp merged commit 6940b8b into firefly-cpp:main Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants