Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Refactor Actions and Thunks #3300

Closed
codehag opened this issue Jul 11, 2017 · 1 comment
Closed

Refactor Actions and Thunks #3300

codehag opened this issue Jul 11, 2017 · 1 comment
Labels
👷‍♀️ Code Health discussion

Comments

@codehag
Copy link
Contributor

codehag commented Jul 11, 2017 •
edited
Loading

We have a bit of congestion in our reducers and actions. In this step the goal will be to:

  • make our actions as close to pure as possible
  • expose a clear api for the thunks to use, that can later be translated to sagas

I found this thread quite interesting in my thinking about this. reduxjs/redux#1171

a couple of comments I would like to point out are:

  • dtinth commented on Dec 28, 2015 (2nd comment)
  • slorber commented on Dec 28, 2015 (2nd comment)
  • dtinth commented on Dec 28, 2015 (4th comment)
  • gaearon commented on Dec 29, 2015
  • tommikaikkonen commented on Feb 17, 2016
@codehag codehag mentioned this issue Jul 11, 2017
Closed
@codehag codehag changed the title Refactor actions and thunks Refactor Actions and Thunks Jul 11, 2017
@jasonLaster jasonLaster modified the milestone: July 25th Jul 11, 2017
@jasonLaster
Copy link
Contributor

closing as we're working on refactoring as we go. These are great comments.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
👷‍♀️ Code Health discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasonLaster @codehag