fix invalid shares #1866
Merged
fix invalid shares #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With rocm we fighted very long with invalid shares. This is now solved with rocm 1.9 and this tiny fix. It is not fully clear where a memory optimization is kicking in and break the kernel `Groestl` if the variables `M` and `H` are not `volatile`. The performance ill not change with this fix. The fix is tested with rocm 1.9 with a VEGA64 and a RX570
This was referenced Oct 5, 2018
fireice-uk
approved these changes
Oct 5, 2018
This was referenced Oct 5, 2018
Open
Zarkoob
reviewed
Oct 9, 2018
|
2.5.1 compiled with the change specified here, still resulting in almost 100% invalid shares. amdgpu-pro-18.30-641594 on R9 380 TONGA. rocm not supported on these older GPUs. |
|
AMD driver 18.3 is broken you must use ROCm 1.9.X under linux.
…On Sat, Oct 20, 2018 at 12:58 AM mbranchick ***@***.***> wrote:
2.5.1 compiled with the change specified here, still resulting in almost
100% invalid shares.
amdgpu-pro-18.30-641594
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1866 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AYsxtjF9qmpdz4kq23wKSHyZg-tX1FNgks5umlkBgaJpZM4XK37Z>
.
|
|
But Tonga can't work with ROCm
|
|
I'm using amdgpu-pro-opencl-17.50.552542 with xmr-stak-2.5.1 to get valid results on Tonga
|
|
17.50 or earlier also works, and is all you can do for older GPUs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With rocm we fighted very long with invalid shares. This is now solved with rocm 1.9 and
this tiny fix.
It is not fully clear where a memory optimization is kicking in and break the kernel
Groestlif the variablesMandHare notvolatile.The performance ill not change with this fix.
The fix is tested with rocm 1.9 with a VEGA64 and a RX570