Garbled .ini "SMOKEFIREPROP" #1430
Comments
|
I was missing a '\n' character in a print statement. thanks for the
catch. I'll post again when I'm able to post an updated smokeview. I'm
working on a couple of other bugs at the moment
…On Fri, Sep 9, 2022 at 12:47 PM obscureed ***@***.***> wrote:
This is a slightly tricksy bug to replicate, but I think the following
steps demonstrate it:
(1) Run any project in FDS6.7.9. (I've added a small example,
tunnel0003.fds, renamed as tunnel0003.txt, in case it matters.)
(2) Open the results in the corresponding SMV6.7.21. Save the settings.
Copy the resulting .ini file to step2.ini. Close smokeview.
(3) Open the results in a new session of smokeview. Save the settings.
Copy the resulting .ini file to step3.ini.
(4) Display some results -- for example, 3D visualisation of HRRPUV. Pause
the results display by pressing "t". Save the settings. Copy the resulting
.ini file to step4.ini.
Now compare the .ini files. There are differences between step2.ini and
step3.ini, but they seem to be benign. The (presumed) bug is that step2.ini
and step3.ini contain this text:
SMOKEFIREPROP
0 1SMOKEPROP
8700.000000
which I suspect is a garbled version of the equivalent in step4.ini:
SMOKEPROP
8700.000000
If SMOKEFIREPROP is a parameter name, then the bug is also that step4.ini
does not contain it.
I'm seeing this behaviour on the Jun 28 2022 build, Revision
SMV6.7.21-0-gccbc561da-release, LINUX64 platform.
tunnel0003.txt
<https://github.com/firemodels/smv/files/9537091/tunnel0003.txt>
—
Reply to this email directly, view it on GitHub
<#1430>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC6UCRXTNGCI2E23NP4LKOLV5NSYZANCNFSM6AAAAAAQI23AZ4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Glenn Forney
|
|
I would have preferred more descriptive names than SMOKEPROP and SMOKEFIREPROP -- SMOKE3DEXTINCTION, for example. |
|
wanted to leave open the option of adding other smoke or fire properties if needed to these keywords. |
|
From my perspective as a user, descriptive names are helpful. If a new smoke property is added, it is helpful if it is given a new descriptive name, rather than lumped with unrelated numbers into one catchall name. I sometimes have to hunt through the .ini file for a relevant-sounding parameter name, and then experiment with it to see if it does what I want. The documentation does not describe all the relevant parameters -- it does not currently mention SMOKEPROP or SMOKEFIREPROP, for example. |
|
should be fixed in smokeview posted here |
|
did the smokeview I posted fix your issue? |
|
Sorry, it will be a few days before I have time to test this. |
|
I've tried that test version of smokeview on the test case I posted. The three .ini files are all different from each other in various ways, which I find slightly odd. In particular, step4.ini is missing the settings of SMOKEFIREPROP that are present in the earlier step2.ini and step3.ini. Can it be correct that displaying some results destroys a setting? Even so, the .ini files are not garbled, so I'll mark this as closed. Thanks for your efforts! |
|
Reopening because I think there are a couple of similar missing '\n' issues in saved .ini files: I haven't seen any problems because of these, so I'm just highlighting for info. No need from me for a patched version, thanks. |
|
thanks. should be fixed in smokeview's posted here
https://drive.google.com/drive/folders/0B_wB1pJL2bFQc1F4cjJWY2duWTA?resourcekey=0-J_yHat7iJoBp1fk6QS8gMA&usp=sharing
…On Tue, Oct 18, 2022 at 9:33 AM obscureed ***@***.***> wrote:
Reopening because I think there are a couple of similar missing '\n'
issues in saved .ini files:
• end of numeric line after "CO2COLOR" (or start of DIRECTIONCOLOR)
• end of numeric line after "SHOWHRRPLOT" (or start of SHOWMISSINGOBJECTS)
I haven't seen any problems because of these, so I'm just highlighting for
info. No need from me for a patched version, thanks.
—
Reply to this email directly, view it on GitHub
<#1430 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC6UCRTIKS6BHIUGHJXF7A3WD2RLDANCNFSM6AAAAAAQI23AZ4>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
--
Glenn Forney
|
|
Great, thanks. I've verified the patched version and am closing the issue. |
This is a slightly tricksy bug to replicate, but I think the following steps demonstrate it:
(1) Run any project in FDS6.7.9. (I've added a small example, tunnel0003.fds, renamed as tunnel0003.txt, in case it matters.)
(2) Open the results in the corresponding SMV6.7.21. Save the settings. Copy the resulting .ini file to step2.ini. Close smokeview.
(3) Open the results in a new session of smokeview. Save the settings. Copy the resulting .ini file to step3.ini.
(4) Display some results -- for example, 3D visualisation of HRRPUV. Pause the results display by pressing "t". Save the settings. Copy the resulting .ini file to step4.ini.
Now compare the .ini files. There are differences between step2.ini and step3.ini, but they seem to be benign. The (presumed) bug is that step2.ini and step3.ini contain this text:
which I suspect is a garbled version of the equivalent in step4.ini:
If SMOKEFIREPROP is a parameter name, then the bug is also that step4.ini does not contain it.
I'm seeing this behaviour on the Jun 28 2022 build, Revision SMV6.7.21-0-gccbc561da-release, LINUX64 platform.
tunnel0003.txt
The text was updated successfully, but these errors were encountered: