Br deps #83
Merged
Br deps #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 8, 2019 20:30
committing in case the power goes out
fileDeps() to builders for richer dependency tracking.
a0u
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt at detecting if buildroot is up to date. See #21.
Hashing the rootfs doesn't work because each build changes the rootfs (probably a timestamp somewhere), so we have to manually try to track down all the dependencies.
The dependencies this pr tracks are:
Notably absent is anything in br/buildroot/. I'm not sure how to reliably track what is/isn't up to date there. If you manually rebuild buildroot (e.g. 'cd br/buildroot && make'), marshal will notice and rebuild the children. I think in the rare cases that someone is modifying buildroot itself (rather than the config or overlays), they can just re-run make manually to pick up the changes.