fix(gateway): answer with empty list of addresses on DNS resolution failure #4266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Terraform Cloud Plan Output |
Performance Test ResultsTCP
UDP
|
conectado
reviewed
Mar 22, 2024
| Ok(Err(e)) => { | ||
| tracing::warn!("Failed to resolve '{domain}': {e}"); | ||
|
|
||
| vec![] |
There was a problem hiding this comment.
We should probably have a dedicated message for this, but for now maybe we need to handle it from the client-side disconnecting from the gateway.
This will be left in a weird state connected to a gateway which might have no resources associated.
There was a problem hiding this comment.
It could be superious? It prompted me to write up #4267.
conectado
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a failure during DNS resolution results in the client hanging during the connection setup. Instead, we fall back to an empty list which results in an empty DNS query result for the client.
That in turn will make most application consider the DNS request failed. As far as I know, we don't currently retry these DNS requests, meaning a user would have to sign-in and out again to fix this state.
Whilst not ideal, I think this is a better behaviour and what we currently have where the initial connection just hangs.