-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(connlib): emit INFO logs for resource changes #5473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Converting to draft because it is stacked. |
Terraform Cloud Plan Output
|
Performance Test ResultsTCP
UDP
|
jamilbk
approved these changes
Jun 21, 2024
thomaseizinger
force-pushed
the
refactor/dns-translation-on-gateway
branch
from
June 21, 2024 04:09
fe6cced
to
f3e770f
Compare
thomaseizinger
force-pushed
the
chore/connlib/resource-change-logs
branch
from
June 21, 2024 04:11
a653886
to
b131854
Compare
ReactorScram
approved these changes
Jun 21, 2024
thomaseizinger
force-pushed
the
refactor/dns-translation-on-gateway
branch
from
June 24, 2024 00:14
f3e770f
to
5e2a885
Compare
thomaseizinger
force-pushed
the
chore/connlib/resource-change-logs
branch
from
June 24, 2024 00:16
b131854
to
96dd074
Compare
Co-authored-by: Jamil <jamilbk@users.noreply.github.com> Signed-off-by: Thomas Eizinger <thomas@eizinger.io>
thomaseizinger
force-pushed
the
chore/connlib/resource-change-logs
branch
from
June 25, 2024 00:29
96dd074
to
66e7a68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When operating just the headless client, it is currently impossible to know, when resources become activate / inactive. To fix this, we add INFO logs every time we activate or deactivate a resource. This should also prove useful when debugging issues with customers because we now have a timestamped record of what resources were active at that time.