Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(connlib): emit INFO logs for resource changes #5473

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

thomaseizinger
Copy link
Member

When operating just the headless client, it is currently impossible to know, when resources become activate / inactive. To fix this, we add INFO logs every time we activate or deactivate a resource. This should also prove useful when debugging issues with customers because we now have a timestamped record of what resources were active at that time.

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 0:30am

@thomaseizinger thomaseizinger marked this pull request as draft June 20, 2024 23:27
@thomaseizinger
Copy link
Member Author

Converting to draft because it is stacked.

Copy link

github-actions bot commented Jun 20, 2024

Terraform Cloud Plan Output

Plan: 15 to add, 23 to change, 2 to destroy.

Terraform Cloud Plan

Copy link

github-actions bot commented Jun 20, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 231.3 MiB (-1%) 233.0 MiB (-1%) 258 (+15%)
direct-tcp-server2client 238.8 MiB (+0%) 240.3 MiB (+0%) 421 (-0%)
relayed-tcp-client2server 244.8 MiB (+4%) 246.3 MiB (+4%) 522 (+31%)
relayed-tcp-server2client 230.8 MiB (-1%) 232.0 MiB (-0%) 762 (+17%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (+0%) 0.03ms (-22%) 42.38% (-0%)
direct-udp-server2client 500.0 MiB (+0%) 0.02ms (-57%) 23.35% (+10%)
relayed-udp-client2server 499.9 MiB (-0%) 0.04ms (-17%) 55.49% (+3%)
relayed-udp-server2client 500.0 MiB (+0%) 0.04ms (+15%) 32.53% (-7%)

rust/connlib/tunnel/src/dns.rs Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger force-pushed the refactor/dns-translation-on-gateway branch from fe6cced to f3e770f Compare June 21, 2024 04:09
@thomaseizinger thomaseizinger force-pushed the chore/connlib/resource-change-logs branch from a653886 to b131854 Compare June 21, 2024 04:11
@thomaseizinger thomaseizinger force-pushed the refactor/dns-translation-on-gateway branch from f3e770f to 5e2a885 Compare June 24, 2024 00:14
@thomaseizinger thomaseizinger force-pushed the chore/connlib/resource-change-logs branch from b131854 to 96dd074 Compare June 24, 2024 00:16
Base automatically changed from refactor/dns-translation-on-gateway to main June 24, 2024 23:57
thomaseizinger and others added 2 commits June 25, 2024 10:29
Co-authored-by: Jamil <jamilbk@users.noreply.github.com>
Signed-off-by: Thomas Eizinger <thomas@eizinger.io>
@thomaseizinger thomaseizinger force-pushed the chore/connlib/resource-change-logs branch from 96dd074 to 66e7a68 Compare June 25, 2024 00:29
@thomaseizinger thomaseizinger marked this pull request as ready for review June 25, 2024 00:29
@thomaseizinger thomaseizinger added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit 72e726f Jun 25, 2024
156 checks passed
@thomaseizinger thomaseizinger deleted the chore/connlib/resource-change-logs branch June 25, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants