Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.3.4] sendDigitalPort : why not using existing method ? #54

Closed
corsaire50 opened this issue May 11, 2013 · 1 comment
Closed

[v2.3.4] sendDigitalPort : why not using existing method ? #54

corsaire50 opened this issue May 11, 2013 · 1 comment

Comments

@corsaire50
Copy link

void FirmataClass::sendDigitalPort(byte portNumber, int portData)
{
FirmataSerial->write(DIGITAL_MESSAGE | (portNumber & 0xF));
//FirmataSerial->write((byte)portData % 128); // Tx bits 0-6 <- removed
//FirmataSerial->write(portData >> 7); // Tx bits 7-13 <- removed
FirmataSerial->sendValueAsTwo7bitBytes(portData); <- added
}

@soundanalogous
Copy link
Member

that would work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants