enable baud rate for serial feature to be updated #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,6 +65,7 @@ | |||
| #define SERIAL_CLOSE 0x50 | |||
| #define SERIAL_FLUSH 0x60 | |||
| #define SERIAL_LISTEN 0x70 | |||
| #define SERIAL_UPDATE_BAUD 0x80 | |||
There was a problem hiding this comment.
Data bytes cannot be > 0x7F in Firmata. I made the same mistake when I drafted FirmataSerial. I'm proposing a 2.0 release to make this feature more scalable. It will not be backwards compatible, but it's the best way to move forward here IMO: firmata/protocol#71.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.