Serial 2.0 proposal #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
soundanalogous
force-pushed
the
serial-2
branch
3 times, most recently
from
a797b15
to
a91d7f6
Compare
soundanalogous
force-pushed
the
serial-2
branch
from
a91d7f6
to
e32df74
Compare
|
How does this PR relate to #79 ? Should the two be merged or this one closed maybe? |
|
It doesn't relate. This is for a breaking change to Serial, whereas #79 is for Stepper 2.0. |
|
Ah, misread the title... Never mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces Serial 1.0 and uses a new command ID to maintain backwards compatibility. Serial 1.0 will be deprecated.
The short story on this change is that I really messed up the first version of Serial, limiting scalability and worst of all potentially propagating a pattern of using command IDs in a way that I don't want propagated in new feature proposals. Each new feature should use a full byte for the command ID and never OR any additional data into that byte.
I think most Firmata clients that have implemented the Serial feature should be able to implement this new version without breaking their existing APIs.