Move JS to header #48
Conversation
| @@ -6,11 +6,13 @@ | |||
| <meta name="viewport" content="initial-scale=1" /> | |||
| <title>appname</title> | |||
| <%%= stylesheet_link_tag :application, media: "all" %> | |||
| <%%= javascript_include_tag :application %> | |||
There was a problem hiding this comment.
I feel that this change is not needed. But don't feel strongly about it either.
|
@michiels Can you add to the Changelog? |
|
Right. I keep forgetting that. Sorry!
|
|
I'll keep reminding you, don't worry |
|
Added a ChangeLog entry! Will need to merge the other PRs of course. Maybe it's a good thing to update master branch with an unreleased changelog entry as soon as the previous version is released, that way every contributor can start adding changelogs under the correct heading straight away |
michiels
force-pushed
the
js-in-header
branch
from
8949c43
to
85718a2
Compare
michiels
force-pushed
the
js-in-header
branch
from
85718a2
to
e42c4b1
Compare
|
@jvanbaarsen can I/you merge this in? |
This is a fix for #44. I've chosen to just move the partial inside head, but I also extracted the regular javascript include line to make the application.html.erb look more like the Rails default file.
Fixes #44