Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Separate changelog/description for additional files. #5

Open
iChun opened this issue Jan 21, 2024 · 2 comments
Open

Feature: Separate changelog/description for additional files. #5

iChun opened this issue Jan 21, 2024 · 2 comments
Labels
enhancement New feature or request shipped Issue has been resolved in a release

Comments

@iChun
Copy link

iChun commented Jan 21, 2024

I've seen from trial and from poking around in the code that the changelog for additional files are taken from the parent file. Would appreciate a way to set a different changelog to said additional files.

Thank you!

EDIT: I suppose this could also potentially be extended to file display names as well

@hypherionmc
Copy link
Member

Hmm good point.

I'm thinking for this, maybe I can change the additional file method, to either take in just a file, or an Object, which would allow overriding the file display name and changelog.

If those properties are not defined, it will just fall back to the globally defined ones

hypherionmc added a commit that referenced this issue Jan 22, 2024
@hypherionmc
Copy link
Member

Implemented with 2.0.3

// Additional files to upload with a custom display name and changelog.
// Currently only supported on Curseforge
addAdditionalFile {
    // File, Task or String
    artifact jar
    displayName "Some Name"
    changelog "Hello Changelog"
}

Kotlin DSL

// Additional files to upload with a custom display name and changelog.
// Currently supports CurseForge only
addAdditionalFile {
    // File, Task or String
    artifact(tasks.jar)
    displayName("Test Name")
    changelog("Some Changelog")
}

@hypherionmc hypherionmc added enhancement New feature or request shipped Issue has been resolved in a release labels Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request shipped Issue has been resolved in a release
Projects
None yet
Development

No branches or pull requests

2 participants