update_manpage_completions.py is run on every new shell

[nagisa]

Every invocation of fish command built from today’s git (44e94b8) will fire off update_manpage_completions.py script which consumes substantial amount of resources.

Might be related to #997. If nobody can reproduce it I'll bisect.

Possibly also related, but might also be not – I ran fish_update_completions manually just after freshly installing git version of fish. Can’t tell whether that is what caused the behaviour as I built and ran git fish for the first time in a long time.

[nagisa]

Removing the code introduced by commit linked in #997 fixes the issue.

The issue seems to stem from the fact that update_manpage_completions.py puts completions into /home/nagisa/.config/fish/generated_completions/, but my $XDG_CONFIG_HOME is actually /home/nagisa/config (note the missing leading dot).

[zanchey]

Fish detects a non-standard XDG_CONFIG_HOME correctly in __fish_config_interactive.fish, but not in update_manpage_completions.py or in fish_update_completions.fish.

[zanchey]

Additionally, we should probably be storing this stuff in XDG_DATA_HOME rather than XDG_CONFIG_HOME.

[mrak]

I'll add a vote for these generated files (that are currently under XDG_CONFIG_HOME to go under XDG_DATA_HOME:

generated_completions/
fish_read_history
fish_history
fishd.<hostname>

[zanchey]

See #744 and #1257 regarding those files.

[siteshwar]

@zanchey #1350 looks ok ?