Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move non-config data out of $XDG_CONFIG_HOME #1669

Closed
lilyball opened this issue Sep 7, 2014 · 6 comments
Closed

Move non-config data out of $XDG_CONFIG_HOME #1669

lilyball opened this issue Sep 7, 2014 · 6 comments

Comments

@lilyball
Copy link
Contributor

lilyball commented Sep 7, 2014

As per #862, non-config data like fish_history, fishd.*, generated_completions, etc. should be moved out of $XDG_CONFIG_HOME and into $XDG_DATA_HOME instead. This would enable easy syncing of ~/.config/fish between machines.

@lilyball lilyball added this to the next-major milestone Sep 7, 2014
@RSully
Copy link

RSully commented Sep 8, 2014

So no chance of seeing this added in a minor release?

@zanchey
Copy link
Member

zanchey commented Sep 8, 2014

See also #744, #1257

@zanchey
Copy link
Member

zanchey commented Sep 8, 2014

generated_completions moving out of $XDG_CONFIG_HOME is #1343 with #1350 .

@lilyball
Copy link
Contributor Author

lilyball commented Sep 8, 2014

@RSully It can happen in a minor release if someone gets around to doing it. I just stuck it in next-major because I don't want to promise it in a minor release.

@zanchey zanchey removed this from the next-major milestone Sep 29, 2014
@zanchey
Copy link
Member

zanchey commented Sep 29, 2014

I'm closing this as a dupe of #1257 - can we track there?

@zanchey zanchey closed this as completed Sep 29, 2014
@RSully
Copy link

RSully commented Oct 26, 2014

Sure, could you tag that issue for the milestone/label so it doesn't get lost?

jeffkowalski added a commit to jeffkowalski/fish-shell that referenced this issue Sep 17, 2015
Add new functions path_get_data and path_create_data which parallel existing
functions path_get_config and path_create_data.  The new functions refer to
XDG_DATA_HOME, if it is defined, or ./local/share if not.

Modify history_filename to use the new function path_get_data.

As a consequence, fish_history will now be located in XDG_DATA_HOME,
not XDG_CONFIG_HOME.

Note that these changes mirror what is already used in
fish-shell/share/tools/create_manpage_completions.py, which stores the
completions in XDG_DATA_HOME

This change matches recommendations in the xdg basedir spec at
http://standards.freedesktop.org/basedir-spec/basedir-spec-0.7.html
($XDG_DATA_HOME defines the base directory relative to which user specific data
files should be stored. If $XDG_DATA_HOME is either not set or empty, a default
equal to $HOME/.local/share should be used.)

It addresses suggestions from the following issues:

1. Don't put history in $XDG_CONFIG_HOME fish-shell#744
   fish-shell#744

2. Fish is placing non-config files in $XDG_CONFIG_HOME fish-shell#1257
   fish-shell#1257

3. Move non-config data out of $XDG_CONFIG_HOME fish-shell#1669
   fish-shell#1669
zanchey pushed a commit that referenced this issue Oct 15, 2015
Add new functions path_get_data and path_create_data which parallel existing
functions path_get_config and path_create_data.  The new functions refer to
XDG_DATA_HOME, if it is defined, or ./local/share if not.

Modify history_filename to use the new function path_get_data.

As a consequence, fish_history will now be located in XDG_DATA_HOME,
not XDG_CONFIG_HOME.

Note that these changes mirror what is already used in
fish-shell/share/tools/create_manpage_completions.py, which stores the
completions in XDG_DATA_HOME

This change matches recommendations in the xdg basedir spec at
http://standards.freedesktop.org/basedir-spec/basedir-spec-0.7.html
($XDG_DATA_HOME defines the base directory relative to which user specific data
files should be stored. If $XDG_DATA_HOME is either not set or empty, a default
equal to $HOME/.local/share should be used.)

It addresses suggestions from the following issues:

1. Don't put history in $XDG_CONFIG_HOME (closes #744)
   #744

2. Fish is placing non-config files in $XDG_CONFIG_HOME #1257
   #1257

3. Move non-config data out of $XDG_CONFIG_HOME #1669
   #1669
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants