Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psub cleanup not happening in event handlers #7792

faho opened this issue Mar 7, 2021 · 0 comments

Psub cleanup not happening in event handlers #7792

faho opened this issue Mar 7, 2021 · 0 comments


Copy link

faho commented Mar 7, 2021

As reported by @marcusatiliusregulus on gitter:

function f --on-event fish_prompt
    source (echo "echo hello world" | psub)

causes psub to not clean up after itself - the "on-job-exit caller" event is never run. This causes issues with pyenv, because that still uses source (thing | psub) internally, and so it will lead to a lot of files in $TMPDIR.

This is caused by f7e2e7d forbidding job handlers inside event handlers from running. I'm going to soften it to still allow caller-exit handlers.

@faho faho added the regression label Mar 7, 2021
@faho faho added this to the fish 3.2.1 milestone Mar 7, 2021
@faho faho closed this as completed in 3715163 Mar 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

No branches or pull requests

1 participant