Potentially loading javascript multiple times on a page

[ddrury]

Admittedly this is a bit contrived but ...

Assumes ckeditor is enabled.

Whenever the configure option for a block is clicked, block_edit.php initialises ckeditor, now if instead of saving the pop-up contents, the dialog is cancelled (by clicking on the overlay for example) then the ckeditor javascript remains loaded. Repeating the process results in a another lot of JS being loaded ad nauseum

I've used the sledgehammer method to "solve" it. Using my proposed modal dialog changes, I've added window.location.reload() to modalDialog close - not very satisfactory but it works.

This isn't incorporated in the pull request.

Is Modernizr.load() still causing problems?

[fisharebest]

@ddrury - I'm guessing your recent patch to fix dialogs containing the CKeditor has fixed this issue...

[ddrury]

Yeah, seems to be. Must be due to CKEditor changes - absolutely nothing
to do with me!!

Regards
David
Please consider the environment before printing this e-mail

------ Original Message ------
From: "Greg Roach" notifications@github.com
To: "fisharebest/webtrees" webtrees@noreply.github.com
Cc: "David Drury" david@drury.me.uk
Sent: 21/06/2014 04:39:36
Subject: Re: [webtrees] Potentially loading javascript multiple times on
a page (#73)

@ddrury - I'm guessing your recent patch to fix dialogs containing the
CKeditor has fixed this issue...

—
Reply to this email directly or view it on GitHub.