Fixes #4119

[magicsunday]

No description provided.

[codecov]

Codecov Report

Merging #4152 (0298df8) into main (4ff9827) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main    #4152   +/-   ##
=========================================
  Coverage     25.85%   25.85%           
  Complexity    11209    11209           
=========================================
  Files          1572     1572           
  Lines         48270    48270           
=========================================
  Hits          12480    12480           
  Misses        35790    35790           

Impacted Files	Coverage Δ
app/Module/InteractiveTreeModule.php	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ff9827...0298df8. Read the comment docs.

[fisharebest]

webtrees should only generate these URLs with an xref parameter.

This error only comes from search engines. It suggests that somewhere webtrees is generating a URL without the xref paramter.

This fix will get rid of the error messages - but I want to discover where this invalid URL is generated.

If a request does not include a mandatory parameter (and webtrees only generates valid URLs), the the request with the missing parameter should receive a 400 status error message.

There is a new Validation class which generates these exceptions.

[magicsunday]

Do you mean something like this?

$xref = Validator::queryParams($request)->isXref()->requiredString('xref');

[fisharebest]

Do you mean something like this?

$xref = Validator::queryParams($request)->isXref()->requiredString('xref');

Yes.

[fisharebest]

Do you mean something like this?
$xref = Validator::queryParams($request)->isXref()->requiredString('xref');

I have implemented this.