-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some implementations on CloudCore #8
Conversation
cloud/pkg/cloudhub/cloudhub.go
Outdated
@@ -64,7 +64,9 @@ func (a *cloudHub) Start() { | |||
// start dispatch message from the cloud to edge node | |||
go messageq.DispatchMessage() | |||
|
|||
httpserver.SignCerts() | |||
httpserver.PrepareForAllCert() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PrepareForAllCerts
"fmt" | ||
hubconfig "github.com/kubeedge/kubeedge/cloud/pkg/cloudhub/config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this line below L33
"fmt" | ||
hubconfig "github.com/kubeedge/kubeedge/cloud/pkg/cloudhub/config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
|
||
import ( | ||
"bytes" | ||
hubconfig "github.com/kubeedge/kubeedge/cloud/pkg/cloudhub/config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty line above
cloud/pkg/cloudhub/config/config.go
Outdated
Cert []byte | ||
Key []byte | ||
} | ||
|
||
const ( | ||
rootCaFile= "/etc/kubeedge/ca/rootCA.key" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rootCaKeyFile
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I will write it in cloudhubconfig like ca and servercerts and delete the delete these two lines
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add a specific implementation on CloudCore.
Which issue(s) this PR fixes:
Fixes #
Ref: kubeedge#1443