Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some implementations on CloudCore #8

Merged
merged 6 commits into from
Apr 28, 2020
Merged

Conversation

ls889
Copy link
Collaborator

@ls889 ls889 commented Apr 27, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind test
/kind failing-test

/kind feature

What this PR does / why we need it:
Add a specific implementation on CloudCore.

Which issue(s) this PR fixes:

Fixes #

Ref: kubeedge#1443

@ls889 ls889 changed the title Mycerts Add some implementations on CloudCore Apr 27, 2020
@@ -64,7 +64,9 @@ func (a *cloudHub) Start() {
// start dispatch message from the cloud to edge node
go messageq.DispatchMessage()

httpserver.SignCerts()
httpserver.PrepareForAllCert()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PrepareForAllCerts

"fmt"
hubconfig "github.com/kubeedge/kubeedge/cloud/pkg/cloudhub/config"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this line below L33

"fmt"
hubconfig "github.com/kubeedge/kubeedge/cloud/pkg/cloudhub/config"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto


import (
"bytes"
hubconfig "github.com/kubeedge/kubeedge/cloud/pkg/cloudhub/config"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line above

Cert []byte
Key []byte
}

const (
rootCaFile= "/etc/kubeedge/ca/rootCA.key"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rootCaKeyFile ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I will write it in cloudhubconfig like ca and servercerts and delete the delete these two lines

@fisherxu fisherxu merged commit 1c61036 into fisherxu:certs Apr 28, 2020
fisherxu pushed a commit that referenced this pull request Aug 5, 2020
* Upgraded k8s to x.18.6

* Updated vendor folder

* added files in vendor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants