Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use BorderlessFullscreen instead of true fullscreen (fix alt+tab) #391

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

MaxCWhitehead
Copy link
Collaborator

@MaxCWhitehead MaxCWhitehead commented Apr 22, 2024

Using borderless fullscreen mode fixes alt tab not working in fullscreen. Probably should support both - but this seems like a preferable default.

One side effect I see in jumpy is that when fullscreen on high res display the UI scaling no longer gets tiny (now looks as I'd expect). I'd show screenshots to compare, but the screenshot tool on macOS doesn't work in true fullscreen mode either 😉

Any concerns with this?

@zicklag
Copy link
Member

zicklag commented Apr 22, 2024

My only thought is that on Linux with gnome there was a weird thing at some point where you could only get full-performance without random skips by running in exclusive full screen. But I'm not sure if that's an issue anymore or if they fixed it, so probably not worth dodging it at the moment.

If we were some super high-performance game it might be worth having an exclusive fullscreen option, because I think it's good for performance, because I think it can skip the system compositor, but we're probably good.

@MaxCWhitehead MaxCWhitehead added this pull request to the merge queue Apr 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 22, 2024
@MaxCWhitehead MaxCWhitehead added this pull request to the merge queue Apr 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 22, 2024
@MaxCWhitehead MaxCWhitehead merged commit e94841d into fishfolk:main Apr 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants