Fix HLS OpenAPI warning #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
- Coverage 87.12% 87.08% -0.04%
==========================================
Files 74 76 +2
Lines 1538 1541 +3
==========================================
+ Hits 1340 1342 +2
- Misses 198 199 +1
Continue to review full report in Codecov by Sentry.
|
sgfn
reviewed
May 23, 2024
Rados13
force-pushed
the
debug
branch
3 times, most recently
from
b0a94e2
to
3afc38d
Compare
sgfn
reviewed
May 28, 2024
Co-authored-by: Jakub Pisarek <99591440+sgfn@users.noreply.github.com>
Karolk99
approved these changes
Jun 3, 2024
| @@ -37,29 +39,34 @@ defmodule Fishjam.Component.HLS.ManagerTest do | |||
| hls_dir: hls_dir, | |||
| options: options | |||
| } do | |||
| MockManager.http_mock_expect(0, status_code: 200) | |||
| Application.put_env(:ex_aws, :awscli_auth_adapter, Fishjam.Adapter) | |||
| pid = MockManager.start_mock_engine() | ||
|
|
||
| {:ok, manager} = Manager.start(room_id, pid, hls_dir, options) | ||
| ref = Process.monitor(manager) | ||
|
|
||
| assert Process.alive?(pid) |
There was a problem hiding this comment.
I don't think this is necessary, as next line does the same thing
| @@ -24,9 +24,10 @@ defmodule FishjamWeb.Integration.PeerSocketTest do | |||
|
|
|||
| alias FishjamWeb.PeerSocket | |||
|
|
|||
| socket "/socket/peer", PeerSocket, | |||
| socket("/socket/peer", PeerSocket, | |||
sgfn
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acknowledging the stipulations set forth:
OpenAPI warning is fixed by how object
S3Credentialsis referenced.Error with AuthCache was fixed by providing
AuthConfigAdapter, which is the wayAuthCacheis tested inExAws.