Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change offline mode package cache behaviour #65

Closed
volllly opened this issue Dec 22, 2022 · 0 comments · Fixed by #87
Closed

Change offline mode package cache behaviour #65

volllly opened this issue Dec 22, 2022 · 0 comments · Fixed by #87
Assignees
Labels
feature-request New feature or request

Comments

@volllly
Copy link
Contributor

volllly commented Dec 22, 2022

We want to introduce an "offline package" directory where offline packages are downloaded from into the package cache.

Background

Right now when using offline mode the Launcher does not download packages. The Launcher just looks for the packages inside the package cache directory.

When downloading an offline launcher from the portal the packages will be put in a folder packages in the downloaded .zip file.

The original idea was to set the packageCache config parameter to this folder in the downloaded launcher configuration file like this:

fiskaltrust.Launcher.<cashboxid>.zip/
├── packages/
│   ├── <package1>.zip
│   ├── <package2>.zip
│   └── ...
├── launcher.configuration.json
└── fiskaltrust.Launcher.exe

launcher.configuration.json:

{
  // ...,
  "packageCache": "./packages"
}

Poroposed Change to this Process

Instead of changing the configuration to the change package cache folder we want to automatically copy the packages from the "packages" folder next to the launcher executable to the package cache.

fiskaltrust.Launcher.<cashboxid>.zip/
├── packages/
│   ├── <package1>.zip
│   ├── <package2>.zip
│   └── ...
├── launcher.configuration.json
└── fiskaltrust.Launcher.exe

package cache before starting the Launcher:

<package-cache>/

package cache after starting the Launcher:

<package-cache>/
├── <package1>.zip
├── <package2>.zip
└── ...
@volllly volllly added the feature-request New feature or request label Dec 22, 2022
@volllly volllly changed the title Change offline mode dynamic file path behaviour Change offline mode package cache behaviour Jun 5, 2023
@pawelvds pawelvds self-assigned this Jun 13, 2023
@pawelvds pawelvds linked a pull request Jun 13, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants