Bug metastable plotting #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fispact#45) examples/outputplotting/plotnuclideheat.py - plotting all isotopes of one element with get_all_isotopes as before, here Sc - plotting one specific ZAI with new get_all_isotopes_states, here Sc45m - plotting all isotopes and states of an element with new get_all_isotopes_states, here Sc pypact/analysis/__init__.py - import new get_all_isotopes_states() pypact/analysis/propertyplotter.py - NuclideDataEntry class(): added self.state, IndexError handling if get_all_isotopes() is used instead of of get_all_isotopes_states() - plotproperty(): also distinguish by state, labels pypact/library/nuclidelib.py - new function get_all_isotopes_states(): multiplying by STATE_MAPPINGS
|
This is great! It works well - thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I tried to fix issue 45: having the possibility to distinguish between isotope states for plotting.
Main changes are to NuclideDataEntry class to have a "state" and nuclidelib.py adding a new function get_all_isotopes_states(). By default get_all_isotopes_states() gives back a list of all isotopes and all states of STATE_MAPPINGS (part of which is "m" for metastable). Don't know if it makes sense to include other STATE_MAPPINGS than "m". Also plotproperty distinguishes the state now.
In plotnuclideheat.py I tried the changes by with different plot examples.
The get_all_isotopes() function also continues working (if there is no interest in the state): added IndexError handling in NuclideDataEntry self.state for this purpose. Not sure if that is good practice. :D
Any feedback would be great!