Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Serialize/Deserialize for UCAN #3

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

matheus23
Copy link
Member

@matheus23 matheus23 commented Oct 16, 2023

Also: Take impl AsRef<str> in some places instead of String (and standardize on specifying it as an impl-in-place).
Also also: Encode EmptyCaveat as {} instead of null

Also: Take `impl AsRef<str>` in some places instead of `String`
(and standardize on specifying it as an `impl`-in-place).
@matheus23 matheus23 self-assigned this Oct 16, 2023
@QuinnWilton
Copy link

QuinnWilton commented Oct 23, 2023

Ah, thank you! The issue with EmptyCaveat must have been a subtle regression when I changed things from struct EmptyCaveat {} to struct EmptyCaveat;

@QuinnWilton QuinnWilton merged commit f3e3bff into quinn-wip-rework Oct 23, 2023
3 of 7 checks passed
@matheus23 matheus23 deleted the matheus23/expose-serde branch October 23, 2023 17:22
@matheus23
Copy link
Member Author

Yeah, I think so too.
However, this additionally also fails parsing if there's any fields in the object at all. I think EmptyCaveat {} previously accepted objects with fields, it would simply ignore them IIRC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants