Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ability to add npm access token to builder #216

Merged
merged 1 commit into from
Jan 19, 2022
Merged

add ability to add npm access token to builder #216

merged 1 commit into from
Jan 19, 2022

Conversation

fishman
Copy link
Contributor

@fishman fishman commented Jan 12, 2022

fixes #215

sanketsudake
sanketsudake requested changes Jan 17, 2022
View reviewed changes
nodejs/builder/Dockerfile Outdated Show resolved Hide resolved
nodejs/builder/build.sh Outdated Show resolved Hide resolved
@sanketsudake
Copy link
Member

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Jan 19, 2022

rebase

✅ Branch has been successfully rebased

@sanketsudake sanketsudake merged commit ce9be54 into fission:master Jan 19, 2022
@fishman fishman mentioned this pull request Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanketsudake sanketsudake sanketsudake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node-builder needs ability to add npm token via env
2 participants
@fishman @sanketsudake