Support parallel iteration with rayon
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fleshes out a few iteration parts of this crate: * Adds `IterMut` and `IntoIter` iterators for the main `Arena` type. * Adds `DoubleEndedIterator` and `ExactSizeIterator` implementations to all iterators. * Adds a new optional feature, `rayon`, which enables linking to `rayon` and enabling parallel iteration of arenas (all three modes).
alexcrichton
referenced
this pull request
in alexcrichton/id-arena
Jan 25, 2019
fitzgen
approved these changes
Jan 25, 2019
| add_id::<A, _>(self.iter.next(), self.arena_id) | ||
| } | ||
|
|
||
| fn size_hint(&self) -> (usize, Option<usize>) { |
|
Will merge and fix the README locally. |
|
Also FWIW the rayon bits are like 99% copied from the rayon-internal implementation of |
|
Published 2.1.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fleshes out a few iteration parts of this crate:
IterMutandIntoIteriterators for the mainArenatype.DoubleEndedIteratorandExactSizeIteratorimplementations toall iterators.
rayon, which enables linking torayonand enabling parallel iteration of arenas (all three modes).