Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for exceptions ports + aarch64 #64

Closed
wants to merge 1 commit into from

Conversation

bnjbvr
Copy link

@bnjbvr bnjbvr commented Mar 12, 2021

This adds enough support for bytecodealliance/wasmtime#2632 to not add its own bindings, plus it brings up support for Apple Silicon (aarch64) by tweaking/adding a few data structures.

One note for reviewers: yes it's weird, but the count() implementations are indeed different when I look at my local mach header files. They are reflected as such in this PR.

@bnjbvr
Copy link
Author

bnjbvr commented Mar 16, 2021

@gnzlbg @fitzgen can you take a look, please? Thanks!

@fitzgen
Copy link
Owner

fitzgen commented Mar 16, 2021

I haven't been involved in this crate for years, so I'll defer to @gnzlbg.

@bnjbvr
Copy link
Author

bnjbvr commented Mar 14, 2022

Happy birthday to this PR!
I understand maintenance can be a bad burden, but since this happens to be used in Rust libc, wonder if there's a simple way forward with little friction, like what's proposed in #63 (comment), what do you think @fitzgen?

@bnjbvr
Copy link
Author

bnjbvr commented Apr 11, 2022

Revived as JohnTitor/mach2#8

@bnjbvr bnjbvr closed this Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants