Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore modal styles "swal2" when purging unused CSS #20 #27

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

sedan07
Copy link

@sedan07 sedan07 commented Feb 8, 2021

The CSS for the modal window was missing as it gets added dynamically to the HTML. Ignoring anything prefixed with swal2- when purging unused styles seems to solve the issue.

@codecov-io
Copy link

Codecov Report

Merging #27 (5ed3464) into 2.5 (b797f36) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.5      #27      +/-   ##
============================================
+ Coverage     55.88%   55.92%   +0.04%     
  Complexity     1264     1264              
============================================
  Files           275      275              
  Lines          4803     4803              
============================================
+ Hits           2684     2686       +2     
+ Misses         2119     2117       -2     
Impacted Files Coverage Δ Complexity Δ
app/Integrations/Core/System.php 87.17% <0.00%> (+2.56%) 13.00% <0.00%> (ø%)
app/Presenters/ComponentPresenter.php 100.00% <0.00%> (+5.26%) 10.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b797f36...5ed3464. Read the comment docs.

@sedan07 sedan07 merged commit ac36057 into 2.5 Feb 8, 2021
@sedan07 sedan07 deleted the 20-broken-delete-modal branch February 25, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants