ember-cli-babel@6 compatibility #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simply renames the export
removes babel 6 package.json and uses afterRender fix to pass test @josex2r
Closed
fivetanley
reviewed
Apr 17, 2017
app/helpers/await.js
Outdated
| @@ -1 +1 @@ | |||
| export { default, await } from 'ember-promise-helpers/helpers/await'; | |||
| export { default, awaitFor } from 'ember-promise-helpers/helpers/await'; | |||
There was a problem hiding this comment.
As far as I can tell, this export doesn't actually exist?
There was a problem hiding this comment.
Ah, this was the autogenerated thing from Ember CLI and you were updating it so it wasn't using async (which i guess is reserved?). Can you change this line to export { default } from 'ember-promise-helpers/helpers/await';?
|
Left a comment but otherwise looks great. Thanks for your help! |
|
We are 🍏 ! |
|
@fivetanley ember-cli-babel bumped up to v6 last weekend so this issue is now super visible and - if possible - a merge and release would be greatly appreciated. Thanks. |
|
@jrjohnson @tylerturdenpants 1.0.3 was just released. Thanks so much!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.