Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt utils snowflake conditional revert #40

Merged
merged 1 commit into from
Sep 20, 2021

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz commented Sep 20, 2021

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

With the patch release of dbt-utils v0.7.3 the snowflake uppercase fix no longer is needed and thus is removed from our int_jira__issue_users model.

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide explanation how the change is non breaking below.)

This simply removes a Snowflake conditional that is no longer needed and is actually breaking users runs currently.

Is this PR in response to a previously created Issue

How did you test the PR changes?

  • CircleCi
  • Other (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🧯

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- and oy we'll definitely have to change this in our other packages...

@fivetran-joemarkiewicz
Copy link
Contributor Author

fivetran-joemarkiewicz commented Sep 20, 2021

lgtm -- and oy we'll definitely have to change this in our other packages...

Thanks for catching this in the other packages! @fivetran-jamie would you be able to open a bug fix request in those other packages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants