feature/performance-improvements #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-joemarkiewicz
requested changes
Apr 16, 2024
integration_tests/dbt_project.yml
Outdated
| @@ -56,7 +60,7 @@ seeds: | |||
| due_date: timestamp | |||
| netsuite2_account_data: | |||
| +column_types: | |||
| eliminate: "{{ 'string' if target.type in ('bigquery', 'spark', 'databricks') else 'varchar' }}" | |||
| eliminate: "{{ 'string' if target.type in ('bigquery', 'spark', 'databricks', 'databricks-sql') else 'varchar' }}" | |||
There was a problem hiding this comment.
The target.type for databricks-sql is still databricks. This update isn't necessary.
fivetran-joemarkiewicz
approved these changes
Apr 19, 2024
Comment on lines
+2
to
+5
| # - package: fivetran/fivetran_utils | ||
| # version: [">=0.4.0", "<0.5.0"] | ||
| - git: https://github.com/fivetran/dbt_fivetran_utils.git | ||
| revision: feature/add-lookback-macro |
There was a problem hiding this comment.
Don't forget to switch once live
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
This PR will result in the following new package version:
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
dbt run (if incremental models are present)Before marking this PR as "ready for review" the following have been applied:
docs were regenerated (unless this PR does not include any code or yml updates)Detailed Validation
Please share any and all of your validation steps: