Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link in Shopify transform package README #38

Merged
merged 3 commits into from
Aug 15, 2022
Merged

Fix broken link in Shopify transform package README #38

merged 3 commits into from
Aug 15, 2022

Conversation

fivetran-chloe
Copy link
Contributor

@fivetran-chloe fivetran-chloe commented Aug 11, 2022 •
edited
Loading

Fixes a broken link in the Shopify transform package README, as noted in Slack. The rest of the README's URLs are functional.

@fivetran-chloe fivetran-chloe self-assigned this Aug 11, 2022
@fivetran-chloe fivetran-chloe added bug Something isn't working documentation Improvements or additions to documentation labels Aug 11, 2022
@fivetran-abhijeet fivetran-abhijeet mentioned this pull request Aug 12, 2022
Closed
MitchellRLayton
MitchellRLayton approved these changes Aug 12, 2022
View reviewed changes
Copy link

@MitchellRLayton MitchellRLayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fivetran-joemarkiewicz
fivetran-joemarkiewicz approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend change was needed in order for the integration tests to pass. Once that was updated I was able to see success. LGTM!

@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 3dc788a into main Aug 15, 2022
@fivetran-chloe
Copy link
Contributor Author

Backend change was needed in order for the integration tests to pass. Once that was updated I was able to see success. LGTM!

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fivetran-joemarkiewicz fivetran-joemarkiewicz fivetran-joemarkiewicz approved these changes

@MitchellRLayton MitchellRLayton MitchellRLayton approved these changes

Assignees

@MitchellRLayton MitchellRLayton

@fivetran-chloe fivetran-chloe

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fivetran-chloe @MitchellRLayton @fivetran-joemarkiewicz