add journals #1
Merged
add journals #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukinagae
commented
Mar 17, 2022
client.go
Outdated
| @@ -122,6 +122,85 @@ func (c *Client) postFiles(ctx context.Context, | |||
| return c.do(ctx, oauth2Token, req, res) | |||
| } | |||
|
|
|||
| func (c *Client) downloadFile(ctx context.Context, | |||
There was a problem hiding this comment.
[comment] client.do() の実装をコピーしているのであまり良くない（※単に client.do() 内でjson.Decodeしている処理を避けてresponse.Bodyのバイトを取得しているだけ）
yukinagae
commented
Mar 17, 2022
| queryParams url.Values, | ||
| ) ([]byte, *oauth2.Token, error) { | ||
| // TODO: content-typeはcsv以外もあり得る？ | ||
| req, err := c.newRequest(ctx, apiPath, method, "text/csv", queryParams, nil) |
There was a problem hiding this comment.
[comment] content-typeを text/csv 固定にしてしまっているが、実際にはPDFなどある
There was a problem hiding this comment.
application/pdf や image/* などをダウンロードできるAPIもあるが、
対応したいのはCSVダウンロードのみなので、命名を具体化してTODOを削除。
・downloadFile() -> downloadCSV()
yukinagae
commented
Mar 17, 2022
client.go
Outdated
| return nil, oauth2Token, res | ||
| } | ||
| // TODO: bytesではなくBodyをそのまま返した方がいいかも | ||
| bytes, err := io.ReadAll(response.Body) |
There was a problem hiding this comment.
[comment] []byteではなくresponse.Bodyを返した方がよいかも
yukinagae
commented
Mar 17, 2022
| // 受け付けID | ||
| ID int32 `json:"id"` | ||
| // TODO: 受け付けメッセージ | ||
| Messages *[]string `json:"messages,omitempty"` |
There was a problem hiding this comment.
運用されてからも長く、ここは気にする必要がないとしてTODOを削除した。
（返り値のサンプルでは id でリクエストを受け付けました。）
yukinagae
commented
May 6, 2022
| apiPath string, method string, | ||
| oauth2Token *oauth2.Token, | ||
| queryParams url.Values, | ||
| ) (io.ReadCloser, *oauth2.Token, error) { |
There was a problem hiding this comment.
[comment] io.ReadCloserを返すように変更
yukinagae
force-pushed
the
feature/journals-2
branch
from
3386434
to
2892581
Compare
kaito2
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIリファレンス: https://developer.freee.co.jp/docs/accounting/reference#/Journals/