Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uuid #34

Merged
merged 3 commits into from
Sep 26, 2016
Merged

Uuid #34

merged 3 commits into from
Sep 26, 2016

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Sep 23, 2016

No description provided.

@phadej
Copy link
Collaborator Author

phadej commented Sep 23, 2016

Seems that instances in quickcheck-instances generate subseconds. Either we could use checkUrlPiece' or own equality.

EDIT went with first option, for know. quickcheck-instances generate subsecond times, which fail to roundtrip with this package atm

@fizruk
Copy link
Owner

fizruk commented Sep 25, 2016

There was an issue on UUID before — #21. @gregwebs had some points to not have uuid dependency here.

@phadej
Copy link
Collaborator Author

phadej commented Sep 25, 2016

bummer. uuid is an extremely light dependency.
So far it's 2-1 for having uuid (assuming @fizruk is 👍 and @gregwebs is 👎).

Continuing from #21, cuid is nice too, and it's instances could be here too, but when interoperating with java-world apps, not having UUIDs is no go.

@phadej
Copy link
Collaborator Author

phadej commented Sep 25, 2016

FWIW, I'll redo this PR with depending only uuid-types which is indeed much lighter than uuid

EDIT done

@fizruk fizruk merged commit 9ac2465 into fizruk:master Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants