method to set label before checkbox in CheckboxSetInputBase class #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millevlada
reviewed
Aug 29, 2024
| display: flex; | ||
| align-items: center; | ||
| } | ||
| .ui-cbis-p label { |
There was a problem hiding this comment.
We want extra margin only when label is before checkbox, otherwise it would consume some unwanted space when it is used as after checkbox.
Add separate part of style (label-first) to mark that:
.ui-cbis-p {
padding-right: 10px;
&.label-first {
display: flex;
align-items: center;
label {
margin-right: 4px;
}
}
}
millevlada
reviewed
Aug 29, 2024
| IRenderInto<T> cr = m_actualContentRenderer; | ||
| if(cr == null) | ||
| cr = m_actualContentRenderer = calculateContentRenderer(lv); | ||
| Label span = new Label(); | ||
| span.setForTarget((NodeBase) cb); | ||
| pair.add(span); | ||
| if(m_labelBeforeCheckbox) { | ||
| pair.add(span); |
There was a problem hiding this comment.
add:
span.addCss("label-first");
millevlada
approved these changes
Aug 30, 2024
fjalvingh
approved these changes
Sep 10, 2024
| IRenderInto<T> cr = m_actualContentRenderer; | ||
| if(cr == null) | ||
| cr = m_actualContentRenderer = calculateContentRenderer(lv); | ||
| Label span = new Label(); | ||
| span.setForTarget((NodeBase) cb); | ||
| pair.add(span); | ||
| if(m_labelBeforeCheckbox) { | ||
| span.addCssClass("label-first"); |
There was a problem hiding this comment.
All css classes in DomUI use the ui-prefix combined with the component short code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to set the labels for each checkbox on the left side of the toggle.
The spacing between two filters and their belonging labels are made bigger so it is more clear which label refers to which toggle.