feat: removed computation of drho from standard windowing procedure. #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently looked at simulations where I have access to more than a million samples and noticed that the standard windowing procedure can become very slow because most of the time is spent computing the error of rho which is not needed for the windowing but only when visualizing rho as a function of the window. For this reason I propose to remove the computation of drho for the standard windowing procedure. On my machine in a test setup with 5 million samples and$\tau_\mathrm{int}\approx 150$ the gamma method took 20.4s with the previous version and 820ms after the change.
The only downside that I can see is that the error of rho is not available for every data point when calling the
plot_rho
method. I attached how the output of this method looks like with the changes I propose.