Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Obs in f-strings without specifier #190

Merged
merged 5 commits into from
May 31, 2023
Merged

Fix Obs in f-strings without specifier #190

merged 5 commits into from
May 31, 2023

Conversation

fjosw
Copy link
Owner

@fjosw fjosw commented May 31, 2023

I introduced a bug in #170 which caused Obs in f-strings without a specifier to throw an error

obs = pe.pseudo_Obs(1, 0.1, "test")
print(f"obs={obs}")

This PR fixes this bug.

@fjosw fjosw requested a review from s-kuberski as a code owner May 31, 2023 15:58
@fjosw fjosw merged commit bb43a8a into develop May 31, 2023
@fjosw fjosw deleted the fix/f_strings branch May 31, 2023 17:07
fjosw added a commit that referenced this pull request Jun 1, 2023
@fjosw
Fix Obs in f-strings without specifier (#190)
d339015 
* fix: Conversion of an array with ndim > 0 to a scalar deprecation fixed.

* fix: adjusted maximal value for rho in test_gamma_method_irregular.

* fix: obs in f-strings now work again when no specifier is provided.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-kuberski s-kuberski s-kuberski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fjosw @s-kuberski