Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error when trying to only find idls that are not present #224

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

jkuhl-uni
Copy link
Collaborator

As addressed in #222, this PR introduces an error in case none of the desired idls can be found in the file of the respective replica.

@jkuhl-uni jkuhl-uni requested a review from fjosw as a code owner January 11, 2024 13:04
Copy link
Owner

@fjosw fjosw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Closes #222

@fjosw fjosw merged commit df1873b into fjosw:develop Jan 11, 2024
9 checks passed
@jkuhl-uni jkuhl-uni deleted the fix/no_idls_in_file branch June 19, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants