Improve handling of errors when setting up rendering thread #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dering on the main thread
…Add notes to appRenderingOnMainThread
…e. Improve handling of initialization, simplify Core's state variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monomer uses a secondary thread for rendering to show continuous content updates when the user resizes the window. In some cases, so far only on Linux, the driver will fail when switching the active GL context with this error: "Unable to make GL context current".
With this PR, the library will attempt to fall back to using the main thread for rendering when the referenced error occurs. Additionally, it will not try to set up multi-threaded rendering if the runtime is single-threaded (missing the -threaded flag).
Mentioned in: