Do not discard previous WidgetRequests during selectList's postMerge call #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if viewport did not change
…s remaining after merge exhausted old versions
…selectList and dropdown
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the merge process, child widgets may make
WidgetRequests for different purposes. One of the main ones isResizeWidgets, which thelabelwidget uses for recalculating its glyphs.The
postMergestep inselectList, used bydropdown, discarded previous requests and caused visual issues. Resizing the window, which forces label recalculations, showed that the data was still correct.The fix for the issue is located in
SelectList.hs. The rest of the changes are minor, unrelated improvements inContainer.This is discussed here: #154.